Hashar has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/356598 )

Change subject: Remove transient test
......................................................................

Remove transient test

To phase out the Zend 5.3 jobs (T158652) I wrote a transient test to
assist in the migration.  It is no more needed now.

Bug: T158652
Bug: T166706
Change-Id: Ia8bbb013660e6c6d33e5c4deeeca52b6dfece611
---
M tests/test_zuul_scheduler.py
1 file changed, 0 insertions(+), 83 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/98/356598/1

diff --git a/tests/test_zuul_scheduler.py b/tests/test_zuul_scheduler.py
index 9253093..7b16bcd 100644
--- a/tests/test_zuul_scheduler.py
+++ b/tests/test_zuul_scheduler.py
@@ -607,89 +607,6 @@
 
         self.assertTrue(test_manager.eventMatches(event, change))
 
-    # transient test job to help phasing out Zend 5.3 - T158652
-    def test_mediawiki_release_branches_trigger_phplint(self):
-        def assertChangeTriggersJob(change, job):
-            self.assertTrue(
-                job.changeMatches(change),
-                msg='%s should trigger for branch %s. Job: %s' % (
-                    job.name, change.branch, job.__dict__)
-            )
-
-        def getPipelineJobForProject(job_name, project_name,
-                                     pipeline_name='test'):
-            jobs_tree = [t for (p, t) in
-                         self.getPipeline(pipeline_name).job_trees.iteritems()
-                         if p.name == project_name][0]
-            return [j for j in jobs_tree.getJobs()
-                    if j.name == job_name][0]
-
-        # mediawiki/core
-        change = zuul.model.Change('mediawiki/core')
-        change.files = ['foobar.php']  # php55lint jobs have a files: filter
-        lint_job = getPipelineJobForProject(
-            'mediawiki-core-php55lint', 'mediawiki/core')
-
-        gate_phpunit55_job = getPipelineJobForProject(
-            'mediawiki-phpunit-php55-trusty', 'mediawiki/core',
-            'gate-and-submit')
-
-        change.branch = 'REL1_23'
-        assertChangeTriggersJob(change, lint_job)
-        assertChangeTriggersJob(change, gate_phpunit55_job)
-
-        change.branch = 'REL1_26'  # last that supports Zend 5.3
-        assertChangeTriggersJob(change, lint_job)
-        assertChangeTriggersJob(change, gate_phpunit55_job)
-
-        change.branch = 'REL1_27'  # requires Zend 5.5
-        assertChangeTriggersJob(change, lint_job)
-        assertChangeTriggersJob(change, gate_phpunit55_job)
-
-        change.branch = 'master'
-        assertChangeTriggersJob(change, lint_job)
-        assertChangeTriggersJob(change, gate_phpunit55_job)
-
-        # A MediaWiki extension
-        change = zuul.model.Change('mediawiki/extensions/ConfirmEdit')
-        change.files = ['foobar.php']  # php55lint jobs have a files: filter
-        lint_job = getPipelineJobForProject(
-            'php55lint', 'mediawiki/extensions/ConfirmEdit')
-
-        change.branch = 'REL1_23'
-        assertChangeTriggersJob(change, lint_job)
-
-        change.branch = 'REL1_26'  # last that supports Zend 5.3
-        assertChangeTriggersJob(change, lint_job)
-
-        change.branch = 'REL1_27'  # requires Zend 5.5
-        assertChangeTriggersJob(change, lint_job)
-
-        change.branch = 'master'
-        assertChangeTriggersJob(change, lint_job)
-
-        # Make sure test jobs are properly triggered
-        test_55 = getPipelineJobForProject(
-            'mwext-testextension-php55-trusty',
-            'mediawiki/extensions/ConfirmEdit',
-            'gate-and-submit')
-        gate_55 = getPipelineJobForProject(
-            'mediawiki-extensions-php55-trusty',
-            'mediawiki/extensions/ConfirmEdit',
-            'gate-and-submit')
-
-        change.branch = 'REL1_26'
-        assertChangeTriggersJob(change, test_55)
-        assertChangeTriggersJob(change, gate_55)
-
-        change.branch = 'REL1_27'
-        assertChangeTriggersJob(change, test_55)
-        assertChangeTriggersJob(change, gate_55)
-
-        change.branch = 'master'
-        assertChangeTriggersJob(change, test_55)
-        assertChangeTriggersJob(change, gate_55)
-
     def test_rake_jessie_files_filters(self):
         # FIXME: should be more generic
         jobs_tree = [t for (p, t) in

-- 
To view, visit https://gerrit.wikimedia.org/r/356598
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8bbb013660e6c6d33e5c4deeeca52b6dfece611
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Hashar <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to