Bartosz Dziewoński has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/357327 )
Change subject: Add the ability to set $wgResourceModuleSkinStyles for
'mediawiki.skinning.interface'
......................................................................
Add the ability to set $wgResourceModuleSkinStyles for
'mediawiki.skinning.interface'
'mediawiki.skinning.interface' uses a custom ResourceLoaderFileModule
subclass (ResourceLoaderSkinModule) to automatically include the
styles for the wiki logo. It now works with no other changes needed.
Change-Id: I35a12a451bf2695818702df1bbd1708173a3f9ce
---
M includes/resourceloader/ResourceLoader.php
1 file changed, 9 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/27/357327/1
diff --git a/includes/resourceloader/ResourceLoader.php
b/includes/resourceloader/ResourceLoader.php
index 767046b..6f947d3 100644
--- a/includes/resourceloader/ResourceLoader.php
+++ b/includes/resourceloader/ResourceLoader.php
@@ -575,9 +575,15 @@
$info = $this->moduleInfos[$name];
if (
isset( $info['object'] ) ||
- // This special case is dumb, but we need
$wgResourceModuleSkinStyles
- // to work for 'oojs-ui-core.styles'. See T167042.
- ( isset( $info['class'] ) && $info['class'] !==
'ResourceLoaderOOUIFileModule' )
+ // These special cases are dumb, but not every subclass
of ResourceLoaderFileModule
+ // is necessarily able to handle skinStyles
($wgResourceModuleSkinStyles)...
+ (
+ isset( $info['class'] ) &&
+ // For 'oojs-ui-core.styles' (T167042)
+ $info['class'] !==
'ResourceLoaderOOUIFileModule' &&
+ // For 'mediawiki.skinning.interface'
+ $info['class'] !== 'ResourceLoaderSkinModule'
+ )
) {
return false;
}
--
To view, visit https://gerrit.wikimedia.org/r/357327
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I35a12a451bf2695818702df1bbd1708173a3f9ce
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
