20after4 has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/357354 )
Change subject: Use maniphest.edit in phab_epipe.py
......................................................................
Use maniphest.edit in phab_epipe.py
This is to replace a deprecated conduit method call with the modern
equivalent. (see {T159043})
Unfortunately, I'm not sure how to test this.
Bug: T159043
Change-Id: I15ce22de34253909e01b434fab4041eeabb7db01
---
M modules/phabricator/files/phab_epipe.py
1 file changed, 10 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/54/357354/1
diff --git a/modules/phabricator/files/phab_epipe.py
b/modules/phabricator/files/phab_epipe.py
index a2afa31..8ac38b7 100644
--- a/modules/phabricator/files/phab_epipe.py
+++ b/modules/phabricator/files/phab_epipe.py
@@ -139,11 +139,19 @@
def external_user_comment(task, text):
"""update a task with a comment by id
:param task: int id
- :param email: address of source user
:param text: main comment string
:returns: json
"""
- return phab.maniphest.update(id=task, comments=text)
+
+ taskid = "T%s" % task
+ trns = [
+ {
+ "type": "comment",
+ "value": text
+ }
+ ]
+
+ return phab.maniphest.edit(objectIdentifier=taskid, transactions=trns)
def mail2comment(task, name, date, subject, body, uploads):
"""update a task with a comment by id
--
To view, visit https://gerrit.wikimedia.org/r/357354
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I15ce22de34253909e01b434fab4041eeabb7db01
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: 20after4 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
