jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/357386 )
Change subject: svgo: Update pre-commit hook
......................................................................
svgo: Update pre-commit hook
Remove the --pretty option as svgo outputs a smaller file without it.
The `dev-scripts/svg_check.sh` script also doesn't have this option.
As a result of this change the remote `npm test` job won't fail if
the job was not run locally before committing.
Thanks to Jon for figuring out the issue.
Bug: T142532
Change-Id: Icf6cb2bf0c97a36bff3888bffc6136c26c871ae1
---
M dev-scripts/pre-commit
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
jenkins-bot: Verified
Jdlrobson: Looks good to me, approved
diff --git a/dev-scripts/pre-commit b/dev-scripts/pre-commit
index 19aabf5..66d8854 100755
--- a/dev-scripts/pre-commit
+++ b/dev-scripts/pre-commit
@@ -26,9 +26,7 @@
git-staged-files \*.svg|while map file; do
make nodecheck
echo "Compressing $file"
- # If anyone can figure out how to get the pretty option to work
from the config
- # file, feel free to remove it here.
- node_modules/.bin/svgo --config=.svgo.yml "$file" --pretty
+ node_modules/.bin/svgo --config=.svgo.yml "$file"
git add "$file"
done
}
@@ -74,4 +72,4 @@
return $err
}
-main "$@"
\ No newline at end of file
+main "$@"
--
To view, visit https://gerrit.wikimedia.org/r/357386
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf6cb2bf0c97a36bff3888bffc6136c26c871ae1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Bmansurov <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
