Hello Catrope, Sbisson, jenkins-bot,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/357445
to review the following change.
Change subject: Revert "Throw when unserializing invalid Flow workflow metadata
JSON"
......................................................................
Revert "Throw when unserializing invalid Flow workflow metadata JSON"
This reverts commit f0ba3c357355b394b6b12520c955f9a53a2b5d89.
Change-Id: I945ecda8c013ce537a15dad93daaaeb7e503bd4c
---
M includes/Content/BoardContentHandler.php
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/45/357445/1
diff --git a/includes/Content/BoardContentHandler.php
b/includes/Content/BoardContentHandler.php
index 5ae5266..3d533cc 100644
--- a/includes/Content/BoardContentHandler.php
+++ b/includes/Content/BoardContentHandler.php
@@ -8,7 +8,6 @@
use Flow\Model\UUID;
use FormatJson;
use IContextSource;
-use MWContentSerializationException;
use MWException;
use Page;
@@ -70,7 +69,10 @@
$uuid = null;
if ( !$info ) {
- throw new MWContentSerializationException( 'Failed to
decode blob. It should be JSON representing valid Flow metadata.' );
+ // For transition from wikitext-type pages
+ // Make a plain content object and then when we get a
chance
+ // we can insert a proper object.
+ return $this->makeEmptyContent();
} elseif ( isset( $info['flow-workflow'] ) ) {
$uuid = UUID::create( $info['flow-workflow'] );
}
--
To view, visit https://gerrit.wikimedia.org/r/357445
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I945ecda8c013ce537a15dad93daaaeb7e503bd4c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Sbisson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
