Pgehres has submitted this change and it was merged.
Change subject: Fixing PHP fatal when saving banner
......................................................................
Fixing PHP fatal when saving banner
An object was not created by the time it was supposed to be
used. Obviously this causes problems. Created the object and
voila.
Bug: 45846
Change-Id: I9a2ef497dc230819e5ab58d01dadf1f01d57af4a
---
M special/SpecialNoticeTemplate.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Pgehres: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/special/SpecialNoticeTemplate.php
b/special/SpecialNoticeTemplate.php
index d409e16..069431c 100644
--- a/special/SpecialNoticeTemplate.php
+++ b/special/SpecialNoticeTemplate.php
@@ -915,7 +915,8 @@
}
Banner::updateTranslationMetadata( $pageResult, $name,
$body, $priorityLangs );
-
+
+ $bannerObj = new Banner( $name );
$bannerObj->logBannerChange( 'modified',
$this->getUser(), $initialBannerSettings );
return;
--
To view, visit https://gerrit.wikimedia.org/r/52639
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a2ef497dc230819e5ab58d01dadf1f01d57af4a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Mwalker <[email protected]>
Gerrit-Reviewer: Pgehres <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
