Aude has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/357744 )
Change subject: Fix warning in MwTimeIsoFormatter
......................................................................
Fix warning in MwTimeIsoFormatter
Language::getDatePreferences may return false, if date
format preferences are disabled, so we need to check
if it is an array in addition to in_array check.
Bug: T167360
Change-Id: Ifcc6191c108cc8c86d335274cc51d0dc7bc1136a
---
M lib/includes/Formatters/MwTimeIsoFormatter.php
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/44/357744/1
diff --git a/lib/includes/Formatters/MwTimeIsoFormatter.php
b/lib/includes/Formatters/MwTimeIsoFormatter.php
index cf0127d..9835595 100644
--- a/lib/includes/Formatters/MwTimeIsoFormatter.php
+++ b/lib/includes/Formatters/MwTimeIsoFormatter.php
@@ -105,8 +105,9 @@
*/
private function getDateFormat( $precision ) {
$datePreference = 'dmy';
+ $datePreferences = $this->language->getDatePreferences();
- if ( !in_array( $datePreference,
$this->language->getDatePreferences() ) ) {
+ if ( $datePreferences === false || !in_array( $datePreference,
$datePreferences ) ) {
$datePreference = 'default';
}
--
To view, visit https://gerrit.wikimedia.org/r/357744
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifcc6191c108cc8c86d335274cc51d0dc7bc1136a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
