jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/357821 )
Change subject: Fix possible crash when initializing reading list synchronizer.
......................................................................
Fix possible crash when initializing reading list synchronizer.
The synchronizer contains an instance of Handler, which should be
initialized with the Looper of the main UI thread. If it happens to be
initialized from a background thread (with an uninitialized Looper), it
will crash.
Change-Id: Ifbd07803f845bc0b5467caa808d25fc50b8e2386
---
M app/src/main/java/org/wikipedia/readinglist/sync/ReadingListSynchronizer.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Mholloway: Looks good to me, approved
diff --git
a/app/src/main/java/org/wikipedia/readinglist/sync/ReadingListSynchronizer.java
b/app/src/main/java/org/wikipedia/readinglist/sync/ReadingListSynchronizer.java
index 0051fa9..e1efffd 100644
---
a/app/src/main/java/org/wikipedia/readinglist/sync/ReadingListSynchronizer.java
+++
b/app/src/main/java/org/wikipedia/readinglist/sync/ReadingListSynchronizer.java
@@ -36,7 +36,7 @@
private static final String READING_LISTS_SYNC_OPTION =
"userjs-reading-lists-v1";
private static final ReadingListSynchronizer INSTANCE = new
ReadingListSynchronizer();
- private final Handler syncHandler = new Handler();
+ private final Handler syncHandler = new
Handler(WikipediaApp.getInstance().getMainLooper());
private final SyncRunnable syncRunnable = new SyncRunnable();
public static ReadingListSynchronizer instance() {
--
To view, visit https://gerrit.wikimedia.org/r/357821
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifbd07803f845bc0b5467caa808d25fc50b8e2386
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
