jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/357677 )
Change subject: Always use braces after if
......................................................................
Always use braces after if
Makes if blocks more readable
Change-Id: I9883d46de2a71efdc02ccad19f67ae7c93854611
---
M CentralNoticePageLogPager.php
M maintenance/CleanCNTranslateMetadata.php
2 files changed, 6 insertions(+), 2 deletions(-)
Approvals:
jenkins-bot: Verified
Ejegg: Looks good to me, approved
diff --git a/CentralNoticePageLogPager.php b/CentralNoticePageLogPager.php
index 2d46dd7..8a2ddb9 100644
--- a/CentralNoticePageLogPager.php
+++ b/CentralNoticePageLogPager.php
@@ -80,7 +80,9 @@
// Split the title into banner, message, and language
$titlePieces = explode( "/", $row->rc_title, 2 );
$titleBase = $titlePieces[0];
- if ( array_key_exists( 1, $titlePieces ) ) $language =
$titlePieces[1];
+ if ( array_key_exists( 1, $titlePieces ) ) {
+ $language = $titlePieces[1];
+ }
$pattern = '/Centralnotice-([^-]*)-(.*)/';
preg_match( $pattern, $titleBase, $matches );
$banner = $matches[1];
diff --git a/maintenance/CleanCNTranslateMetadata.php
b/maintenance/CleanCNTranslateMetadata.php
index 11479b2..2cd538f 100644
--- a/maintenance/CleanCNTranslateMetadata.php
+++ b/maintenance/CleanCNTranslateMetadata.php
@@ -56,7 +56,9 @@
);
foreach ( $res as $row ) {
- if ( (int)$row->count === 1 ) continue;
+ if ( (int)$row->count === 1 ) {
+ continue;
+ }
$db->delete(
'revtag',
--
To view, visit https://gerrit.wikimedia.org/r/357677
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9883d46de2a71efdc02ccad19f67ae7c93854611
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
Gerrit-Reviewer: AndyRussG <[email protected]>
Gerrit-Reviewer: Awight <[email protected]>
Gerrit-Reviewer: Cdentinger <[email protected]>
Gerrit-Reviewer: Ejegg <[email protected]>
Gerrit-Reviewer: XenoRyet <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
