jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/357945 )
Change subject: Also drop Revision typehint from $oldRev
......................................................................
Also drop Revision typehint from $oldRev
Already did this in $oldRev, this follows up I4c483d7
Bug: T167359
Change-Id: I8b74932caf1188005155b4cbd8a1ff76066b1604
---
M src/RevisionSliderHooks.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Chad: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/RevisionSliderHooks.php b/src/RevisionSliderHooks.php
index c89b0ec..a46ef36 100644
--- a/src/RevisionSliderHooks.php
+++ b/src/RevisionSliderHooks.php
@@ -29,7 +29,7 @@
return self::$config;
}
- public static function onDiffViewHeader( DifferenceEngine $diff,
Revision $oldRev, $newRev ) {
+ public static function onDiffViewHeader( DifferenceEngine $diff,
$oldRev, $newRev ) {
// sometimes $oldRev can be null (e.g. missing rev), and
perhaps also $newRev (T167359)
if ( !( $oldRev instanceof Revision ) || !( $newRev instanceof
Revision ) ) {
return true;
--
To view, visit https://gerrit.wikimedia.org/r/357945
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b74932caf1188005155b4cbd8a1ff76066b1604
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: Chad <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
