Catrope has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/357964 )
Change subject: Element: Work around browsers that set fractional scrollTop
values
......................................................................
Element: Work around browsers that set fractional scrollTop values
Change-Id: I41a4d65fe78a5398b835ebb300250a8c7cad3613
---
M src/Element.js
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/64/357964/1
diff --git a/src/Element.js b/src/Element.js
index 667ad32..5f61429 100644
--- a/src/Element.js
+++ b/src/Element.js
@@ -607,7 +607,9 @@
scrollTop = body.scrollTop;
body.scrollTop = 1;
- if ( body.scrollTop === 1 ) {
+ // In some browsers (observed in Chrome 56 on Linux Mint 18.1),
+ // body.scrollTop doesn't become exactly 1, but a fractional
value like 0.76
+ if ( Math.round( body.scrollTop ) === 1 ) {
body.scrollTop = scrollTop;
OO.ui.scrollableElement = 'body';
} else {
--
To view, visit https://gerrit.wikimedia.org/r/357964
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I41a4d65fe78a5398b835ebb300250a8c7cad3613
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
