Ottomata has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/357324 )
Change subject: Specifying test dependency on snappy ...................................................................... Specifying test dependency on snappy Without snappy added as test dependency tests will fail on a platform in which the library might not be installed. Looks like in Mac 10.9.4 snappy is not installed by default. Following code is the one used by spark to load natively snappy: https://github.com/rvs/snappy-java/blob/master/src/main/resources/org/xerial/snappy/SnappyNativeLoader.java Bug:T166334 Change-Id: I641d11703850e09d6e6dcca9291a520c88ce76b8 --- M refinery-job/pom.xml 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Ottomata: Verified; Looks good to me, approved diff --git a/refinery-job/pom.xml b/refinery-job/pom.xml index 5c633c7..208e921 100644 --- a/refinery-job/pom.xml +++ b/refinery-job/pom.xml @@ -19,6 +19,19 @@ <artifactId>refinery-core</artifactId> </dependency> + <!-- + adding explicit dep for snappy, otherwise + spark assumes is on the java.library.path + see: https://github.com/rvs/snappy-java/blob/master/src/main/resources/org/xerial/snappy/SnappyNativeLoader.java#L47 + --> + <!-- https://mvnrepository.com/artifact/org.xerial.snappy/snappy-java --> + <dependency> + <groupId>org.xerial.snappy</groupId> + <artifactId>snappy-java</artifactId> + <version>1.1.2.5</version> + <scope>test</scope> + </dependency> + <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-common</artifactId> -- To view, visit https://gerrit.wikimedia.org/r/357324 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I641d11703850e09d6e6dcca9291a520c88ce76b8 Gerrit-PatchSet: 1 Gerrit-Project: analytics/refinery/source Gerrit-Branch: master Gerrit-Owner: Nuria <[email protected]> Gerrit-Reviewer: Joal <[email protected]> Gerrit-Reviewer: Ottomata <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
