jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/354193 )
Change subject: Revert "Dump should return decrypted votes"
......................................................................
Revert "Dump should return decrypted votes"
For large elections the decryption takes too long (same reason tally page
doesn't work) and prohibits use of the dump page because of timeout.
This reverts commit d2eac8c31231136e8df57a30f88ff75d7231f102.
Change-Id: Ic0c145ac87074fe7c38331d6a5add690546e20b6
---
M includes/pages/DumpPage.php
1 file changed, 1 insertion(+), 16 deletions(-)
Approvals:
Huji: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/pages/DumpPage.php b/includes/pages/DumpPage.php
index 5b0261c..71cb1ef 100644
--- a/includes/pages/DumpPage.php
+++ b/includes/pages/DumpPage.php
@@ -58,22 +58,7 @@
if ( !$this->headersSent ) {
$this->sendHeaders();
}
- $record = $row->vote_record;
- if ( $this->election->getCrypt() ) {
- $status = $this->election->getCrypt()->decrypt( $record
);
- if ( !$status->isOK() ) {
- // Decrypt failed, e.g. invalid or absent
private key
- // Still, return the encrypted vote
- echo "<vote>\n<encrypted>" . $record .
"</encrypted>\n</vote>\n";
- } else {
- $decrypted_record = $status->value;
- echo "<vote>\n<encrypted>" . $record .
- "</encrypted>\n<decrypted>" .
$decrypted_record .
- "</decrypted>\n</vote>\n";
- }
- } else {
- echo "<vote>\n<decrypted>" . $record .
"</decrypted>\n</vote>\n";
- }
+ echo "<vote>" . $row->vote_record . "</vote>\n";
}
public function sendHeaders() {
--
To view, visit https://gerrit.wikimedia.org/r/354193
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0c145ac87074fe7c38331d6a5add690546e20b6
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/SecurePoll
Gerrit-Branch: master
Gerrit-Owner: Jalexander <jalexan...@wikimedia.org>
Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: Anomie <bjor...@wikimedia.org>
Gerrit-Reviewer: Huji <huji.h...@gmail.com>
Gerrit-Reviewer: Reedy <re...@wikimedia.org>
Gerrit-Reviewer: Tim Starling <tstarl...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
