Bartosz Dziewoński has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/358479 )
Change subject: ViewCourseAction: Fix "Add students" menu not being expandable
......................................................................
ViewCourseAction: Fix "Add students" menu not being expandable
Just remove `href="#"` from the menu custom toggle.
It does nothing and was never needed, and since change
2d95d36a8ed296813e686e9b756c2bb7c306950f in MediaWiki clicks
on such toggles are ignored by jquery.makeCollapsible code.
I think all this could be a made a lot simpler, eh.
Bug: T167651
Change-Id: I64d9b7c4a187c1ebbd1de74ac958c822470de9c4
---
M includes/actions/ViewCourseAction.php
1 file changed, 0 insertions(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EducationProgram
refs/changes/79/358479/1
diff --git a/includes/actions/ViewCourseAction.php
b/includes/actions/ViewCourseAction.php
index 73dc2d4..d1bed5a 100644
--- a/includes/actions/ViewCourseAction.php
+++ b/includes/actions/ViewCourseAction.php
@@ -352,7 +352,6 @@
'a',
[
'class' =>
'mw-customtoggle-addstudents',
- 'href' => '#'
],
$expandMsg
)
--
To view, visit https://gerrit.wikimedia.org/r/358479
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I64d9b7c4a187c1ebbd1de74ac958c822470de9c4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EducationProgram
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
