MaxSem has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/358496 )

Change subject: Use strtr() for clarity
......................................................................

Use strtr() for clarity

Change-Id: I35e7530c13fee028ea95a56df1bd2714a610db6e
---
M includes/Sanitizer.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/96/358496/1

diff --git a/includes/Sanitizer.php b/includes/Sanitizer.php
index b15e4f8..6928559 100644
--- a/includes/Sanitizer.php
+++ b/includes/Sanitizer.php
@@ -1190,7 +1190,7 @@
                ];
 
                $id = urlencode( strtr( $id, ' ', '_' ) );
-               $id = str_replace( array_keys( $replace ), array_values( 
$replace ), $id );
+               $id = strtr( $id, $replace );
 
                if ( !preg_match( '/^[a-zA-Z]/', $id ) && !in_array( 
'noninitial', $options ) ) {
                        // Initial character must be a letter!

-- 
To view, visit https://gerrit.wikimedia.org/r/358496
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I35e7530c13fee028ea95a56df1bd2714a610db6e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: MaxSem <maxsem.w...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to