Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/358501 )
Change subject: base/puppet: add "daemonize = no" to agent config ...................................................................... base/puppet: add "daemonize = no" to agent config This setting prevents puppet from daemonizing. Tested with a typo like "puppet agent 0tv" as described on T166371 it works and prevents it from running. So instead of adding the monitoring for this, i suggest to add this to the config and prevent it from happening in the first place. https://docs.puppet.com/puppet/latest/man/agent.html "Do not send the process into the background. (This is a Puppet setting, and can go in puppet.conf. Note the special 'no-' prefix for boolean settings on the command line.)" Bug: T166371 Change-Id: Ie3e3a02b193380cddd9d80465fee16d80fe7644f --- M modules/base/templates/puppet.conf.d/10-main.conf.erb 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Faidon Liambotis: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/base/templates/puppet.conf.d/10-main.conf.erb b/modules/base/templates/puppet.conf.d/10-main.conf.erb index fd6dfc0..8a475b4 100644 --- a/modules/base/templates/puppet.conf.d/10-main.conf.erb +++ b/modules/base/templates/puppet.conf.d/10-main.conf.erb @@ -20,6 +20,7 @@ <%- end -%> <% if @certname %>certname = <%= @certname %><% end %> <% if @dns_alt_names %>dns_alt_names = <%= @dns_alt_names %><% end %> +daemonize = no configtimeout = 960 usecacheonfailure = false splay = true -- To view, visit https://gerrit.wikimedia.org/r/358501 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3e3a02b193380cddd9d80465fee16d80fe7644f Gerrit-PatchSet: 3 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Dzahn <dz...@wikimedia.org> Gerrit-Reviewer: Faidon Liambotis <fai...@wikimedia.org> Gerrit-Reviewer: Gehel <guillaume.leder...@wikimedia.org> Gerrit-Reviewer: Giuseppe Lavagetto <glavage...@wikimedia.org> Gerrit-Reviewer: Volans <rcocci...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
