Santhosh has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/358514 )
Change subject: CX2: Add oojs as dependency to mw.cx.dm module
......................................................................
CX2: Add oojs as dependency to mw.cx.dm module
mw.cx.dm is the base RL module for CX2 modules. Since all other
classes inherits from OOJS, it is better to have oojs loaded in the
very beginning of the dependency chain.
Currently it is loaded as dependency to mw.cx.dm.Model. I get random
OO undefined error from mw.cx.dm.SourcePage module in debug mode now.
This patch prevents it.
Change-Id: I7092a279236bd5132cf3b79dc85315e21f75631b
---
M extension.json
1 file changed, 3 insertions(+), 3 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation
refs/changes/14/358514/1
diff --git a/extension.json b/extension.json
index 52b5b6f..3df9b61 100644
--- a/extension.json
+++ b/extension.json
@@ -1199,7 +1199,8 @@
"dm/mw.cx.dm.js"
],
"dependencies": [
- "ext.cx.model"
+ "ext.cx.model",
+ "oojs"
]
},
"mw.cx.dm.Model": {
@@ -1209,8 +1210,7 @@
"dm/mw.cx.dm.ModelFactory.js"
],
"dependencies": [
- "mw.cx.dm",
- "oojs"
+ "mw.cx.dm"
]
},
"mw.cx.dm.Translation": {
--
To view, visit https://gerrit.wikimedia.org/r/358514
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7092a279236bd5132cf3b79dc85315e21f75631b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
