jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/358305 )
Change subject: Title::newFromText() can and does return null
......................................................................
Title::newFromText() can and does return null
Bug: T167615
Change-Id: I3a2598379141d8cff5e15dfdc461a0ef8d28316c
---
M src/UserNameSessionProvider.php
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Umherirrender: Looks good to me, approved
jenkins-bot: Verified
Cboltz: Looks good to me, but someone else must approve
diff --git a/src/UserNameSessionProvider.php b/src/UserNameSessionProvider.php
index c665644..b0be25e 100644
--- a/src/UserNameSessionProvider.php
+++ b/src/UserNameSessionProvider.php
@@ -483,7 +483,7 @@
$url = call_user_func(
$url, $metadata );
}
$internal = Title::newFromText(
$url );
- $known = $internal->isKnown();
+ $known = $internal &&
$internal->isKnown();
if ( $known ) {
$url =
$internal->getFullURL();
}
@@ -514,7 +514,8 @@
$url = call_user_func(
$url, $metadata );
}
$internal = Title::newFromText(
$url );
- if ( $internal->isKnown() ) {
+
+ if ( $internal &&
$internal->isKnown() ) {
$url =
$internal->getLinkURL();
}
$personalurls[ 'logout' ][
'href' ] = $url;
--
To view, visit https://gerrit.wikimedia.org/r/358305
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a2598379141d8cff5e15dfdc461a0ef8d28316c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Auth_remoteuser
Gerrit-Branch: master
Gerrit-Owner: Reedy <re...@wikimedia.org>
Gerrit-Reviewer: Cboltz <mediawiki-l...@cboltz.de>
Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
