jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/358243 )
Change subject: Disable addHelpLink when including special pages
......................................................................
Disable addHelpLink when including special pages
The help link does not make sence on includes special pages and is not
shown. But the style module 'mediawiki.helplink' is still loaded.
This change disables the loading of the module 'mediawiki.helplink' for
included special pages.
Change-Id: I8115dc2e46f3498441c30caede4648d387d55d5d
---
M includes/specialpage/SpecialPage.php
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Umherirrender: Looks good to me, approved
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specialpage/SpecialPage.php
b/includes/specialpage/SpecialPage.php
index ba58e92..e861afe 100644
--- a/includes/specialpage/SpecialPage.php
+++ b/includes/specialpage/SpecialPage.php
@@ -783,6 +783,10 @@
* @since 1.25
*/
public function addHelpLink( $to, $overrideBaseUrl = false ) {
+ if ( $this->including() ) {
+ return;
+ }
+
global $wgContLang;
$msg = $this->msg( $wgContLang->lc( $this->getName() ) .
'-helppage' );
--
To view, visit https://gerrit.wikimedia.org/r/358243
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8115dc2e46f3498441c30caede4648d387d55d5d
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Fomafix <foma...@googlemail.com>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
