Shirayuki has uploaded a new change for review.
https://gerrit.wikimedia.org/r/52736
Change subject: Adding comments for grep
......................................................................
Adding comments for grep
Change-Id: I41509950593a13ad15284190e70ca609f5dab5e0
---
M ArticleFeedback.hooks.php
M SpecialArticleFeedback.php
M modules/jquery.articleFeedback/jquery.articleFeedback.js
3 files changed, 30 insertions(+), 0 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticleFeedback
refs/changes/36/52736/1
diff --git a/ArticleFeedback.hooks.php b/ArticleFeedback.hooks.php
index a8072ad..d194e9d 100644
--- a/ArticleFeedback.hooks.php
+++ b/ArticleFeedback.hooks.php
@@ -297,6 +297,23 @@
}
protected static function buildRatingMessagesArray() {
+ // Give grep a chance to find the usages:
+ // articlefeedback-field-trustworthy-label,
articlefeedback-field-trustworthy-tip
+ // articlefeedback-field-trustworthy-tooltip-1,
articlefeedback-field-trustworthy-tooltip-2
+ // articlefeedback-field-trustworthy-tooltip-3,
articlefeedback-field-trustworthy-tooltip-4
+ // articlefeedback-field-trustworthy-tooltip-5
+ // articlefeedback-field-complete-label,
articlefeedback-field-complete-tip
+ // articlefeedback-field-complete-tooltip-1,
articlefeedback-field-complete-tooltip-2
+ // articlefeedback-field-complete-tooltip-3,
articlefeedback-field-complete-tooltip-4
+ // articlefeedback-field-complete-tooltip-5
+ // articlefeedback-field-objective-label,
articlefeedback-field-objective-tip
+ // articlefeedback-field-objective-tooltip-1,
articlefeedback-field-objective-tooltip-2
+ // articlefeedback-field-objective-tooltip-3,
articlefeedback-field-objective-tooltip-4
+ // articlefeedback-field-objective-tooltip-5
+ // articlefeedback-field-wellwritten-label,
articlefeedback-field-wellwritten-tip
+ // articlefeedback-field-wellwritten-tooltip-1,
articlefeedback-field-wellwritten-tooltip-2
+ // articlefeedback-field-wellwritten-tooltip-3,
articlefeedback-field-wellwritten-tooltip-4
+ // articlefeedback-field-wellwritten-tooltip-5
global $wgArticleFeedbackRatingTypes;
$messages = array();
foreach ( $wgArticleFeedbackRatingTypes as $key ) {
diff --git a/SpecialArticleFeedback.php b/SpecialArticleFeedback.php
index 4544ca9..5a48b18 100644
--- a/SpecialArticleFeedback.php
+++ b/SpecialArticleFeedback.php
@@ -543,6 +543,9 @@
protected static function getCategories() {
global $wgArticleFeedbackRatingTypes;
+ // Give grep a chance to find the usages:
+ // articlefeedback-field-trustworthy-label,
articlefeedback-field-complete-label
+ // articlefeedback-field-objective-label,
articlefeedback-field-wellwritten-label
if ( !isset( self::$categories ) ) {
foreach ( $wgArticleFeedbackRatingTypes as $id =>
$rating ) {
self::$categories[$id] = wfMessage(
"articlefeedback-field-$rating-label" )->text();
diff --git a/modules/jquery.articleFeedback/jquery.articleFeedback.js
b/modules/jquery.articleFeedback/jquery.articleFeedback.js
index 235ef69..a803fd2 100644
--- a/modules/jquery.articleFeedback/jquery.articleFeedback.js
+++ b/modules/jquery.articleFeedback/jquery.articleFeedback.js
@@ -525,6 +525,11 @@
.find( '.articleFeedback-ratings' )
.each( function() {
for ( var key in
context.options.ratings ) {
+ // Give grep a chance
to find the usages:
+ //
articlefeedback-field-trustworthy-tip, articlefeedback-field-complete-tip
+ //
articlefeedback-field-objective-tip, articlefeedback-field-wellwritten-tip
+ //
articlefeedback-field-trustworthy-label, articlefeedback-field-complete-label
+ //
articlefeedback-field-objective-label, articlefeedback-field-wellwritten-label
var tipMsg =
'articlefeedback-field-' + key + '-tip',
labelMsg =
'articlefeedback-field-' + key + '-label';
$(
$.articleFeedback.tpl.rating )
@@ -772,6 +777,11 @@
.addClass(
'articleFeedback-rating-label-hover-head' )
.prevAll(
'.articleFeedback-rating-label' )
.addClass( 'articleFeedback-rating-label-hover-tail' );
+ // Give grep a chance
to find the usages:
+ //
articlefeedback-field-trustworthy-tooltip-*
+ //
articlefeedback-field-complete-tooltip-*
+ //
articlefeedback-field-objective-tooltip-*
+ //
articlefeedback-field-wellwritten-tooltip-*
$rating
.find(
'.articleFeedback-rating-tooltip' )
.text( mw.msg(
'articlefeedback-field-' + $rating.attr( 'rel' ) + '-tooltip-' + $el.attr(
'rel' ) ) )
--
To view, visit https://gerrit.wikimedia.org/r/52736
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I41509950593a13ad15284190e70ca609f5dab5e0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticleFeedback
Gerrit-Branch: master
Gerrit-Owner: Shirayuki <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
