VolkerE has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/358922 )
Change subject: WikimediaUI theme: Variablize PopupButtonWidget values
......................................................................
WikimediaUI theme: Variablize PopupButtonWidget values
Variablizing PopupButtonWidget CSS values.
Also
* re-aligning close button,
* relying on same implicit height logic as elsewhere instead of
prone to scalability issues explicit way,
* cleaning-up selectors.
Change-Id: Ie2a2786d06505b2fa9e8b7ddfd85ddfab99b1af9
---
M src/themes/wikimediaui/common.less
M src/themes/wikimediaui/widgets.less
2 files changed, 17 insertions(+), 13 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/22/358922/1
diff --git a/src/themes/wikimediaui/common.less
b/src/themes/wikimediaui/common.less
index f0b522a..b5b820e 100644
--- a/src/themes/wikimediaui/common.less
+++ b/src/themes/wikimediaui/common.less
@@ -102,7 +102,6 @@
@margin-dialog-bar-button-framed: 6 / @oo-ui-font-size-browser /
@oo-ui-font-size-default;
@margin-search: 12 / @oo-ui-font-size-browser / @oo-ui-font-size-default;
@margin-taboption: @margin-dialog-bar-button-framed;
-@margin-button-close: 4 / @oo-ui-font-size-browser / @oo-ui-font-size-default;
@margin-top-tagitem: 4 / @oo-ui-font-size-browser / @oo-ui-font-size-default;
@margin-top-tagmultiselect-input: 6 / @oo-ui-font-size-browser /
@oo-ui-font-size-default;
@margin-top-fieldlayout-help: -( 6 / @oo-ui-font-size-browser /
@oo-ui-font-size-default );
diff --git a/src/themes/wikimediaui/widgets.less
b/src/themes/wikimediaui/widgets.less
index 9919bbc..1f78a4a 100644
--- a/src/themes/wikimediaui/widgets.less
+++ b/src/themes/wikimediaui/widgets.less
@@ -1065,26 +1065,31 @@
}
&-head {
- height: 2.5em;
-
- > .oo-ui-buttonWidget {
- top: @margin-button-close;
- right: @margin-button-close;
+ > .oo-ui-labelElement-label {
+ margin: @padding-top-menu
@padding-start-input-text-icon-label @padding-bottom-menu
@padding-horizontal-default;
+ line-height: @line-height-widget-singleline;
}
- > .oo-ui-labelElement-label {
- margin: 0.75em @padding-start-input-text-icon-label
0.75em 1em;
+ > .oo-ui-buttonWidget {
+ // `top: 0;` not needed as default value
+ right: 0;
}
}
&-body {
- line-height: 1.4;
+ line-height: @line-height-message;
+
+ &-padded {
+ margin: @padding-top-menu @padding-horizontal-default
@padding-bottom-menu;// Use `margin` rather than `padding` to enable margin to
collapse
+
+ :first-child {
+ margin-top: 0;
+ }
+ }
}
- &-body-padded {
- // Use `margin` rather than `padding` to allow the margin to
collapse with
- // the margin of other elements inside the popup
- margin: 0.75em 1em;
+ &-footer {
+ margin: @padding-top-menu @padding-horizontal-default
@padding-bottom-menu;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/358922
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie2a2786d06505b2fa9e8b7ddfd85ddfab99b1af9
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
