Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/359363 )
Change subject: Hygiene: Variable tweaks
......................................................................
Hygiene: Variable tweaks
* redColorBase is available in core. So use it.
* The table of contents padding bottom is derived arbitarily. It makes
more sense to derive it from the font size itself. headingMargin has
nothing to do with this value.
Change-Id: I322bfa6e6dd1e1fa54e1b16ca104be137b88217a
---
M resources/mobile.talk.overlays/TalkOverlay.less
M resources/mobile.toc/toc.less
2 files changed, 2 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/63/359363/1
diff --git a/resources/mobile.talk.overlays/TalkOverlay.less
b/resources/mobile.talk.overlays/TalkOverlay.less
index c2134ee..3671eb0 100644
--- a/resources/mobile.talk.overlays/TalkOverlay.less
+++ b/resources/mobile.talk.overlays/TalkOverlay.less
@@ -2,7 +2,7 @@
.talk-overlay {
.error {
- border: solid 1px @redBase;
+ border: solid 1px @colorErrorText;
}
.comment {
diff --git a/resources/mobile.toc/toc.less b/resources/mobile.toc/toc.less
index 43faf3f..d0d6c8f 100644
--- a/resources/mobile.toc/toc.less
+++ b/resources/mobile.toc/toc.less
@@ -1,9 +1,5 @@
@import 'mobile.variables';
-// FIXME: `mobile.` LESS modules should not import `minerva.` LESS modules.
-// Move Minerva specific rules into skinStyles.
-@import 'minerva.variables';
-
@paddingHorizontal: 24px;
@iconSize: 16px;
@iconHeadingGap: 12px;
@@ -40,7 +36,7 @@
font-size: ( 7 * @fontSize ) / 8;
width: auto;
> ul {
- padding-bottom: @fontSize + @headingMargin;
+ padding-bottom: @fontSize * 2;
}
ul {
--
To view, visit https://gerrit.wikimedia.org/r/359363
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I322bfa6e6dd1e1fa54e1b16ca104be137b88217a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
