Jcrespo has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/359404 )
Change subject: SpecialShortPages: Remove index
force(page_redirect_namespace_len)
......................................................................
SpecialShortPages: Remove index force(page_redirect_namespace_len)
Forcing the index when a large namespace like files is added on
a large wiki, which has many media pages (like commonswiki)
generates a bad query plan, making the page take minutes to load.
Removing the force index seems to fix the problem and generate
a better query plan; meanwhile, large wikis like enwiki seem to
continue being fast. I think the FORCE INDEX used to be needed,
but not is not needed anymore, but it creates instead a
regression.
Bug: T168010
Change-Id: Ib059ab8f07204c058e551238ec85ac9d4303f2dc
---
M includes/specials/SpecialShortpages.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/04/359404/2
diff --git a/includes/specials/SpecialShortpages.php
b/includes/specials/SpecialShortpages.php
index 3282a7a..0220c5e 100644
--- a/includes/specials/SpecialShortpages.php
+++ b/includes/specials/SpecialShortpages.php
@@ -47,7 +47,7 @@
'page_is_redirect' => 0
];
$joinConds = [];
- $options = [ 'USE INDEX' => [ 'page' =>
'page_redirect_namespace_len' ] ];
+ $options = [];
// Allow extensions to modify the query
Hooks::run( 'ShortPagesQuery', [ &$tables, &$conds,
&$joinConds, &$options ] );
--
To view, visit https://gerrit.wikimedia.org/r/359404
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib059ab8f07204c058e551238ec85ac9d4303f2dc
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.30.0-wmf.5
Gerrit-Owner: Jcrespo <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
