jenkins-bot has submitted this change and it was merged.
Change subject: Fixed $vCallback comment and removed unused return value.
......................................................................
Fixed $vCallback comment and removed unused return value.
Change-Id: If438d83e1b43c110b3c23e8d0a7705fa0795049f
---
M includes/MappedIterator.php
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Demon: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/MappedIterator.php b/includes/MappedIterator.php
index 243557e..b4376f4 100644
--- a/includes/MappedIterator.php
+++ b/includes/MappedIterator.php
@@ -39,7 +39,7 @@
* The keys of the base iterator are reused verbatim.
*
* @param Iterator|Array $iter
- * @param Closure $callback
+ * @param Closure $vCallback
* @throws MWException
*/
public function __construct( $iter, Closure $vCallback ) {
@@ -81,11 +81,10 @@
}
/**
- * @return Mixed|null Returns null if out of range
+ * @return void
*/
public function next() {
$this->baseIterator->next();
- return $this->current(); // make sure callback is applied
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/52877
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If438d83e1b43c110b3c23e8d0a7705fa0795049f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Demon <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
