Demon has uploaded a new change for review.
https://gerrit.wikimedia.org/r/52893
Change subject: Close a couple of leaking resources
......................................................................
Close a couple of leaking resources
Change-Id: I1d2e4f6d4f07ad25152559304a5b5f414c0c6893
---
M src/org/wikimedia/lsearch/importer/BuildAll.java
M src/org/wikimedia/lsearch/storage/MySQLStorage.java
M src/org/wikimedia/lsearch/util/ConvertFile.java
M test/org/wikimedia/lsearch/util/MathFuncTest.java
4 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/debs/lucene-search-2
refs/changes/93/52893/1
diff --git a/src/org/wikimedia/lsearch/importer/BuildAll.java
b/src/org/wikimedia/lsearch/importer/BuildAll.java
index a54b788..4c41e6b 100644
--- a/src/org/wikimedia/lsearch/importer/BuildAll.java
+++ b/src/org/wikimedia/lsearch/importer/BuildAll.java
@@ -87,6 +87,7 @@
iids.add(IndexId.get(parts[0]));
dumpFiles.put(parts[0],parts[1]);
}
+ reader.close();
} else{
iids.add(IndexId.get(dbname));
dumpFiles.put(dbname,dump);
diff --git a/src/org/wikimedia/lsearch/storage/MySQLStorage.java
b/src/org/wikimedia/lsearch/storage/MySQLStorage.java
index 8a18c6c..74b5098 100644
--- a/src/org/wikimedia/lsearch/storage/MySQLStorage.java
+++ b/src/org/wikimedia/lsearch/storage/MySQLStorage.java
@@ -268,6 +268,7 @@
while((line = file.readLine()) != null){
sb.append(line.replaceFirst("--.*",""));
}
+ file.close();
def = sb.toString();
}
// preprocess dbprefix tags
diff --git a/src/org/wikimedia/lsearch/util/ConvertFile.java
b/src/org/wikimedia/lsearch/util/ConvertFile.java
index 2cf6f9e..7730ae0 100644
--- a/src/org/wikimedia/lsearch/util/ConvertFile.java
+++ b/src/org/wikimedia/lsearch/util/ConvertFile.java
@@ -28,6 +28,7 @@
while((line = in.readLine()) != null){
out.println(line);
}
+ in.close();
out.close();
}
}
diff --git a/test/org/wikimedia/lsearch/util/MathFuncTest.java
b/test/org/wikimedia/lsearch/util/MathFuncTest.java
index c41cebc..28ebfaf 100644
--- a/test/org/wikimedia/lsearch/util/MathFuncTest.java
+++ b/test/org/wikimedia/lsearch/util/MathFuncTest.java
@@ -31,6 +31,7 @@
while((line = r.readLine()) != null){
val2a.add(new Double(line));
}
+ r.close();
double[] val2 = new double[val2a.size()];
for(int i=0;i<val2.length;i++)
val2[i] = val2a.get(i);
--
To view, visit https://gerrit.wikimedia.org/r/52893
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d2e4f6d4f07ad25152559304a5b5f414c0c6893
Gerrit-PatchSet: 1
Gerrit-Project: operations/debs/lucene-search-2
Gerrit-Branch: master
Gerrit-Owner: Demon <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
