Pmiazga has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/359939 )
Change subject: Remove phan supress checks annotation
......................................................................
Remove phan supress checks annotation
Phan configuration is now fixed and it shouldn't throw a false
positive errors when inspecting SpecialElectronPDF class.
Bug: T167995
Change-Id: Ib8e87c75106f6e5df72f1ba29be1857a8b0b4ab0
---
M src/specials/SpecialElectronPdf.php
1 file changed, 0 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ElectronPdfService
refs/changes/39/359939/1
diff --git a/src/specials/SpecialElectronPdf.php
b/src/specials/SpecialElectronPdf.php
index 5773194..d389cac 100644
--- a/src/specials/SpecialElectronPdf.php
+++ b/src/specials/SpecialElectronPdf.php
@@ -16,7 +16,6 @@
public $config;
public function __construct() {
- /** @suppress PhanUndeclaredClassMethod TODO: remove it when
T167995 gets fixed */
parent::__construct( 'ElectronPdf', '', false );
$this->config =
MediaWikiServices::getInstance()->getMainConfig();
}
@@ -201,7 +200,6 @@
}
public function setHeaders() {
- /** @suppress PhanUndeclaredClassMethod TODO: remove it when
T167995 gets fixed */
parent::setHeaders();
$this->addModules();
}
--
To view, visit https://gerrit.wikimedia.org/r/359939
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib8e87c75106f6e5df72f1ba29be1857a8b0b4ab0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ElectronPdfService
Gerrit-Branch: master
Gerrit-Owner: Pmiazga <pmia...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
