jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/358076 )

Change subject: CSS optimization
......................................................................


CSS optimization

Putting $wgResourceModuleSkinStyles into good use in order to not load
unused CSS on every page. This way e.g. TablePager styles are loaded only
when needed.

Removed .imagelist styles as per
https://github.com/wikimedia/mediawiki/commit/6ffb9af8f8d45a863f2ac936e25480d541b73510

Change-Id: I1dcd8ac60e1c5504ddfb667c14fcf38c00cf205f
---
M skin.json
M truglass/main.css
A truglass/mediawiki.action.history.styles.css
A truglass/mediawiki.pager.tablePager.css
4 files changed, 41 insertions(+), 27 deletions(-)

Approvals:
  SamanthaNguyen: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/skin.json b/skin.json
index af740d7..0026da4 100644
--- a/skin.json
+++ b/skin.json
@@ -45,6 +45,8 @@
        "ResourceModuleSkinStyles": {
                "truglass": {
                        "+ext.echo.styles.badge": "truglass/echo.badge.css",
+                       "+mediawiki.action.history.styles": 
"truglass/mediawiki.action.history.styles.css",
+                       "+mediawiki.pager.tablePager": 
"truglass/mediawiki.pager.tablePager.css",
                        "+mediawiki.special.preferences.styles": 
"truglass/special.preferences.styles.css"
                }
        },
diff --git a/truglass/main.css b/truglass/main.css
index 43e8f27..0d27784 100644
--- a/truglass/main.css
+++ b/truglass/main.css
@@ -1597,10 +1597,6 @@
        font-style: italic;
 }
 
-span.updatedmarker {
-       color: black;
-       background-color: #0f0;
-}
 span.newpageletter {
        font-weight: bold;
        color: black;
@@ -1831,29 +1827,6 @@
 table.multipageimage td {
        text-align: center;
 }
-
-/*
-  Table pager (e.g. Special:FileList)
-  - remove underlines from the navigation link
-  - collapse borders
-  - set the borders to outsets (similar to Special:Allmessages)
-  - remove line wrapping for all td and th, set background color
-  - restore line wrapping for the last two table cells (description and size)
-*/
-.TablePager_nav a { text-decoration: none; }
-.TablePager { border-collapse: collapse; }
-.TablePager, .TablePager td, .TablePager th {
-       border: 0.15em solid #777777;
-       padding: 0 0.15em 0 0.15em;
-}
-.TablePager th { background-color: #eeeeff; }
-.TablePager td { background-color: #ffffff; }
-.TablePager tr:hover td { background-color: #eeeeff; }
-
-.imagelist td, .imagelist th { white-space: nowrap; }
-.imagelist .TablePager_col_links { background-color: #eeeeff; }
-.imagelist .TablePager_col_img_description { white-space: normal; }
-.imagelist th.TablePager_sort { background-color: #ccccff; }
 
 .templatesUsed { margin-top: 1.5em; }
 
diff --git a/truglass/mediawiki.action.history.styles.css 
b/truglass/mediawiki.action.history.styles.css
new file mode 100644
index 0000000..bb7f2a6
--- /dev/null
+++ b/truglass/mediawiki.action.history.styles.css
@@ -0,0 +1,5 @@
+/* "Updated since your last visit" marker on the page history of pages that 
are on your watchlist */
+span.updatedmarker {
+       background-color: #0f0;
+       color: #000;
+}
\ No newline at end of file
diff --git a/truglass/mediawiki.pager.tablePager.css 
b/truglass/mediawiki.pager.tablePager.css
new file mode 100644
index 0000000..7a763bc
--- /dev/null
+++ b/truglass/mediawiki.pager.tablePager.css
@@ -0,0 +1,34 @@
+/*
+  Table pager (e.g. Special:FileList)
+  - remove underlines from the navigation link
+  - collapse borders
+  - set the borders to outsets (similar to Special:AllMessages)
+  - remove line wrapping for all td and th, set background color
+  - restore line wrapping for the last two table cells (description and size)
+*/
+.TablePager_nav a {
+       text-decoration: none;
+}
+
+.TablePager {
+       border-collapse: collapse;
+}
+
+.TablePager,
+.TablePager td,
+.TablePager th {
+       border: 0.15em solid #777;
+       padding: 0 0.15em 0 0.15em;
+}
+
+.TablePager th {
+       background-color: #eef;
+}
+
+.TablePager td {
+       background-color: #fff;
+}
+
+.TablePager tr:hover td {
+       background-color: #eef;
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/358076
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1dcd8ac60e1c5504ddfb667c14fcf38c00cf205f
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/skins/Truglass
Gerrit-Branch: master
Gerrit-Owner: Jack Phoenix <[email protected]>
Gerrit-Reviewer: SamanthaNguyen <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to