Wikinaut has submitted this change and it was merged. Change subject: remove errant backslash in XRDS preamble. ......................................................................
remove errant backslash in XRDS preamble. This bit me when I was trying to get Extension:OpenID to work with OpenID auth on my Gerrit installation. Since removing this backslash made it work, I'm assuming that it may fix other bugs elsewhere too. It is supposed to be a typo, dating back earlier than 2008 (https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/OpenID.git;a=blob;f=SpecialOpenIDXRDS.body.php;hb=418d1aa02730c2beb037a8bd90d971c830a291c7) Change-Id: Ida19d8f554b7ce7f5ed2b979cc6221f1de7217e4 --- M SpecialOpenIDXRDS.body.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Wikinaut: Verified; Looks good to me, approved diff --git a/SpecialOpenIDXRDS.body.php b/SpecialOpenIDXRDS.body.php index 37ca596..f45bd82 100644 --- a/SpecialOpenIDXRDS.body.php +++ b/SpecialOpenIDXRDS.body.php @@ -53,7 +53,7 @@ // XRDS preamble XML. $xml_template = array( '<?xml version="1.0" encoding="UTF-8"?' . '>', - '<xrds:XRDS xmlns:xrds="xri://\$xrds" xmlns:openid="http://openid.net/xmlns/1.0"; xmlns="xri://$xrd*($v*2.0)">', + '<xrds:XRDS xmlns:xrds="xri://$xrds" xmlns:openid="http://openid.net/xmlns/1.0"; xmlns="xri://$xrd*($v*2.0)">', '<XRD>', ); -- To view, visit https://gerrit.wikimedia.org/r/52756 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida19d8f554b7ce7f5ed2b979cc6221f1de7217e4 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/OpenID Gerrit-Branch: master Gerrit-Owner: FastLizard4 <[email protected]> Gerrit-Reviewer: Wikinaut <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
