jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/360092 )
Change subject: Fix FunctionComment.Missing sniff code
......................................................................
Fix FunctionComment.Missing sniff code
Since it has periods in it, we need to include the full sniff code,
which should start with the "MediaWiki" prefix. Otherwise it's
impossible to ignore using <exclude name="...">.
Change-Id: I9a2a1fad8ec489702f45a4803d7a3decdaf53133
---
M MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php
b/MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php
index 28464e3..8ae12c6 100644
--- a/MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php
+++ b/MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php
@@ -107,7 +107,8 @@
$phpcsFile->addError(
'Missing function doc comment',
$stackPtr,
- "FunctionComment.Missing.$visStr"
+ "MediaWiki.FunctionComment.Missing.$visStr"
+ // Note: because we include . in the code, we
need the "MediaWiki" standard prefix
);
$phpcsFile->recordMetric( $stackPtr, 'Function has doc
comment', 'no' );
return;
--
To view, visit https://gerrit.wikimedia.org/r/360092
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a2a1fad8ec489702f45a4803d7a3decdaf53133
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/tools/codesniffer
Gerrit-Branch: master
Gerrit-Owner: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
