Legoktm has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/360138 )
Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.9.0
......................................................................
build: Updating mediawiki/mediawiki-codesniffer to 0.9.0
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionComment.MissingParamComment
* MediaWiki.Commenting.FunctionComment.MissingParamTag
* MediaWiki.Commenting.FunctionComment.ParamNameNoMatch
Change-Id: Ibe364df6dc58c2bfb04fc6ac267e1a9fa89bc2f9
---
M composer.json
M includes/CookieWarning.hooks.php
M phpcs.xml
3 files changed, 19 insertions(+), 15 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CookieWarning
refs/changes/38/360138/1
diff --git a/composer.json b/composer.json
index 664b9b4..7a306bc 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
{
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
- "mediawiki/mediawiki-codesniffer": "0.7.2",
+ "mediawiki/mediawiki-codesniffer": "0.9.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/includes/CookieWarning.hooks.php b/includes/CookieWarning.hooks.php
index 47b6fa9..22beb7e 100644
--- a/includes/CookieWarning.hooks.php
+++ b/includes/CookieWarning.hooks.php
@@ -61,14 +61,14 @@
$tpl->data['headelement'] = '';
}
$form = Html::openElement( 'form', [ 'method' => 'POST' ] ) .
- Html::submitButton(
- $sk->msg( 'cookiewarning-ok-label' )->text(),
- [
- 'name' => 'disablecookiewarning',
- 'class' => 'mw-cookiewarning-dismiss'
- ]
- ) .
- Html::closeElement( 'form' );
+ Html::submitButton(
+ $sk->msg( 'cookiewarning-ok-label' )->text(),
+ [
+ 'name' => 'disablecookiewarning',
+ 'class' => 'mw-cookiewarning-dismiss'
+ ]
+ ) .
+ Html::closeElement( 'form' );
$cookieImage = Html::openElement( 'div', [ 'class' =>
'mw-cookiewarning-cimage' ] ) .
'🍪' .
@@ -80,19 +80,19 @@
'div',
[ 'class' => 'mw-cookiewarning-container' ]
) .
- ( $isMobile ? $form : '' ) .
+ ( $isMobile ? $form : '' ) .
Html::openElement(
'div',
[ 'class' => 'mw-cookiewarning-text' ]
) .
- ( $isMobile ? $cookieImage : '' ) .
+ ( $isMobile ? $cookieImage : '' ) .
Html::element(
'span',
[],
$sk->msg( 'cookiewarning-info' )->text()
) .
$moreLink .
- ( !$isMobile ? $form : '' ) .
+ ( !$isMobile ? $form : '' ) .
Html::closeElement( 'div' ) .
Html::closeElement( 'div' );
}
diff --git a/phpcs.xml b/phpcs.xml
index d81a292..2c25c60 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -1,8 +1,12 @@
<?xml version="1.0"?>
<ruleset>
- <rule ref="vendor/mediawiki/mediawiki-codesniffer/MediaWiki"/>
+ <rule ref="vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
+ </rule>
<file>.</file>
- <arg name="extensions" value="php,php5,inc"/>
- <arg name="encoding" value="utf8"/>
+ <arg name="extensions" value="php,php5,inc" />
+ <arg name="encoding" value="utf8" />
<exclude-pattern>vendor</exclude-pattern>
</ruleset>
--
To view, visit https://gerrit.wikimedia.org/r/360138
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe364df6dc58c2bfb04fc6ac267e1a9fa89bc2f9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CookieWarning
Gerrit-Branch: master
Gerrit-Owner: Legoktm <lego...@member.fsf.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
