Legoktm has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/360152 )
Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.9.0
......................................................................
build: Updating mediawiki/mediawiki-codesniffer to 0.9.0
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionComment.MissingParamComment
* MediaWiki.Commenting.FunctionComment.MissingParamName
* MediaWiki.Commenting.FunctionComment.MissingParamTag
* MediaWiki.FunctionComment.Missing.Public
* MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment
Change-Id: I490a22fbd57db9b62123147eeafbeaf098121f89
---
M composer.json
M includes/EmailAuthAuthenticationRequest.php
M phpcs.xml
M tests/phpunit/EmailAuthAuthenticationRequestTest.php
M tests/phpunit/EmailAuthSecondaryAuthenticationProviderTest.php
5 files changed, 13 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EmailAuth
refs/changes/52/360152/1
diff --git a/composer.json b/composer.json
index 664b9b4..7a306bc 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
{
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
- "mediawiki/mediawiki-codesniffer": "0.7.2",
+ "mediawiki/mediawiki-codesniffer": "0.9.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/includes/EmailAuthAuthenticationRequest.php
b/includes/EmailAuthAuthenticationRequest.php
index baecb1a..b10463e 100644
--- a/includes/EmailAuthAuthenticationRequest.php
+++ b/includes/EmailAuthAuthenticationRequest.php
@@ -5,7 +5,7 @@
use MediaWiki\Auth\AuthenticationRequest;
use Message;
-class EmailAuthAuthenticationRequest extends AuthenticationRequest {
+class EmailAuthAuthenticationRequest extends AuthenticationRequest {
public $token;
public function getFieldInfo() {
diff --git a/phpcs.xml b/phpcs.xml
index d81a292..72b0010 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -1,8 +1,14 @@
<?xml version="1.0"?>
<ruleset>
- <rule ref="vendor/mediawiki/mediawiki-codesniffer/MediaWiki"/>
+ <rule ref="vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamName" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
+ <exclude name="MediaWiki.FunctionComment.Missing.Public" />
+ <exclude
name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
+ </rule>
<file>.</file>
- <arg name="extensions" value="php,php5,inc"/>
- <arg name="encoding" value="utf8"/>
+ <arg name="extensions" value="php,php5,inc" />
+ <arg name="encoding" value="utf8" />
<exclude-pattern>vendor</exclude-pattern>
</ruleset>
diff --git a/tests/phpunit/EmailAuthAuthenticationRequestTest.php
b/tests/phpunit/EmailAuthAuthenticationRequestTest.php
index f232289..82c8db8 100644
--- a/tests/phpunit/EmailAuthAuthenticationRequestTest.php
+++ b/tests/phpunit/EmailAuthAuthenticationRequestTest.php
@@ -4,7 +4,7 @@
use MediaWiki\Auth\AuthenticationRequestTestCase;
-class EmailAuthAuthenticationRequestTest extends AuthenticationRequestTestCase
{
+class EmailAuthAuthenticationRequestTest extends AuthenticationRequestTestCase
{
protected function getInstance( array $args = [] ) {
return new EmailAuthAuthenticationRequest();
}
diff --git a/tests/phpunit/EmailAuthSecondaryAuthenticationProviderTest.php
b/tests/phpunit/EmailAuthSecondaryAuthenticationProviderTest.php
index 6882742..a237eba 100644
--- a/tests/phpunit/EmailAuthSecondaryAuthenticationProviderTest.php
+++ b/tests/phpunit/EmailAuthSecondaryAuthenticationProviderTest.php
@@ -12,7 +12,7 @@
use User;
use Wikimedia\TestingAccessWrapper;
-class EmailAuthSecondaryAuthenticationProviderTest extends MediaWikiTestCase {
+class EmailAuthSecondaryAuthenticationProviderTest extends MediaWikiTestCase {
/** @var
EmailAuthSecondaryAuthenticationProvider|PHPUnit_Framework_MockObject_MockObject
*/
protected $provider;
/** @var AuthManager|PHPUnit_Framework_MockObject_MockObject */
--
To view, visit https://gerrit.wikimedia.org/r/360152
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I490a22fbd57db9b62123147eeafbeaf098121f89
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EmailAuth
Gerrit-Branch: master
Gerrit-Owner: Legoktm <lego...@member.fsf.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
