Legoktm has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/360153 )
Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.9.0
......................................................................
build: Updating mediawiki/mediawiki-codesniffer to 0.9.0
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionComment.MissingParamComment
* MediaWiki.Commenting.FunctionComment.MissingParamName
* MediaWiki.Commenting.FunctionComment.MissingParamTag
* MediaWiki.Commenting.FunctionComment.MissingReturn
* MediaWiki.Commenting.FunctionComment.ParamNameNoMatch
* MediaWiki.FunctionComment.Missing.Protected
* MediaWiki.FunctionComment.Missing.Public
* MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment
Change-Id: I96a93c8c6b794e6b78939c30a3658428f922a370
---
M composer.json
M includes/EventLogging.php
M includes/JsonSchema.php
M phpcs.xml
M tests/phpunit/ValidateSchemaTest.php
5 files changed, 14 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EventLogging
refs/changes/53/360153/1
diff --git a/composer.json b/composer.json
index 3e676f3..858a1ef 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
{
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
- "mediawiki/mediawiki-codesniffer": "0.7.2",
+ "mediawiki/mediawiki-codesniffer": "0.9.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/includes/EventLogging.php b/includes/EventLogging.php
index f56a391..57d1ab4 100644
--- a/includes/EventLogging.php
+++ b/includes/EventLogging.php
@@ -21,7 +21,7 @@
* @see https://w3c.github.io/beacon/#sec-sendBeacon-method
*/
public static function sendBeacon( $url, array $data = [] ) {
- DeferredUpdates::addCallableUpdate( function() use ( $url,
$data ) {
+ DeferredUpdates::addCallableUpdate( function () use ( $url,
$data ) {
$options = $data ? [ 'postData' => $data ] : [];
return Http::post( $url, $options );
} );
@@ -81,7 +81,6 @@
* @return string $json
**/
static function serializeEvent( $encapsulatedEvent ) {
-
$event = $encapsulatedEvent['event'];
if ( count( $event ) === 0 ) {
diff --git a/includes/JsonSchema.php b/includes/JsonSchema.php
index 9194d1f..3d9cd28 100644
--- a/includes/JsonSchema.php
+++ b/includes/JsonSchema.php
@@ -78,7 +78,6 @@
} else {
throw new JsonSchemaException( 'jsonschema-idconvert',
JsonUtil::encodeForMsg( $var ) );
}
-
}
/**
@@ -158,7 +157,6 @@
return null;
break;
}
-
}
/**
@@ -290,7 +288,6 @@
} else {
return $nodetype;
}
-
}
/**
diff --git a/phpcs.xml b/phpcs.xml
index d81a292..1c8d485 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -1,8 +1,17 @@
<?xml version="1.0"?>
<ruleset>
- <rule ref="vendor/mediawiki/mediawiki-codesniffer/MediaWiki"/>
+ <rule ref="vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamName" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingReturn" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
+ <exclude name="MediaWiki.FunctionComment.Missing.Protected" />
+ <exclude name="MediaWiki.FunctionComment.Missing.Public" />
+ <exclude
name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
+ </rule>
<file>.</file>
- <arg name="extensions" value="php,php5,inc"/>
- <arg name="encoding" value="utf8"/>
+ <arg name="extensions" value="php,php5,inc" />
+ <arg name="encoding" value="utf8" />
<exclude-pattern>vendor</exclude-pattern>
</ruleset>
diff --git a/tests/phpunit/ValidateSchemaTest.php
b/tests/phpunit/ValidateSchemaTest.php
index b73c44c..90847b1 100644
--- a/tests/phpunit/ValidateSchemaTest.php
+++ b/tests/phpunit/ValidateSchemaTest.php
@@ -166,4 +166,3 @@
optional properties' );
}
}
-
--
To view, visit https://gerrit.wikimedia.org/r/360153
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I96a93c8c6b794e6b78939c30a3658428f922a370
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Legoktm <lego...@member.fsf.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
