Victor Vasiliev has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/52959


Change subject: Handle connection shutdowns correctly.
......................................................................

Handle connection shutdowns correctly.

Change-Id: I92c123eb0564847701beb45c9ee42362572768c8
---
M rcsub.py
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/rcsub 
refs/changes/59/52959/1

diff --git a/rcsub.py b/rcsub.py
index 4aa4b89..024607f 100644
--- a/rcsub.py
+++ b/rcsub.py
@@ -15,7 +15,8 @@
 }
 
 class MessageRouter(object):
-    subs = {}
+    def __init__(self):
+        self.subs = {}
 
     def subscribe(self, channel, listener):
         if channel not in self.subs:
@@ -33,10 +34,9 @@
                 listener.deliver(message)
 
 class Subscriber(object):
-    channels = []
-
     def __init__(self, target):
         self.target = target
+        self.channels = []
 
     def subscribe(self, channel):
         if len(self.channels) >= config['max_channels']:
@@ -123,7 +123,7 @@
         LineReceiver.connectionMade(self)
         self.subscriber = Subscriber(self)
 
-    def onClose(self, wasClean, code, reason):
+    def connectionLost(self, reason):
         self.subscriber.unsubscribeAll()
 
     def message(self, data):

-- 
To view, visit https://gerrit.wikimedia.org/r/52959
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I92c123eb0564847701beb45c9ee42362572768c8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/rcsub
Gerrit-Branch: master
Gerrit-Owner: Victor Vasiliev <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to