jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/359033 )
Change subject: Make sure the toolbar is shown on top of surface contents even
when not floating
......................................................................
Make sure the toolbar is shown on top of surface contents even when not floating
Toolbar contains various dropdowns, popups and other junk inside that
extends past its normal dimensions. Just set 'z-index: 2' so that it
all shows on top of the surface. 'z-index: 1' is already taken by the
surface overlay (with context menus etc. inside).
Bug: T167616
Change-Id: I2ede6c88be569224c0b2a4e388a133ad98b86a7b
---
M src/ui/styles/ve.ui.Toolbar.css
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ui/styles/ve.ui.Toolbar.css b/src/ui/styles/ve.ui.Toolbar.css
index 597136d..1d960f7 100644
--- a/src/ui/styles/ve.ui.Toolbar.css
+++ b/src/ui/styles/ve.ui.Toolbar.css
@@ -9,11 +9,16 @@
position: relative;
}
+.ve-ui-toolbar > .oo-ui-toolbar-bar {
+ /* Make sure the toolbar is shown on top of surface contents even when
not floating,
+ for correct rendering of dropdowns, popups etc. */
+ z-index: 2;
+}
+
/* PositionedTargetToolbar */
.ve-ui-toolbar-floating > .oo-ui-toolbar-bar {
position: fixed;
top: 0;
- z-index: 2;
border-top: 0;
}
--
To view, visit https://gerrit.wikimedia.org/r/359033
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ede6c88be569224c0b2a4e388a133ad98b86a7b
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: DLynch <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
