jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/359034 )
Change subject: ve.init.mw.DesktopArticleTarget: Remove some hacks ...................................................................... ve.init.mw.DesktopArticleTarget: Remove some hacks No longer needed after I2ede6c88be569224c0b2a4e388a133ad98b86a7b in VisualEditor core. * 'transform: none' from 049a32c60a2243fbafd4b26f63e3ad571da5dd65 (that change does not describe what the issue was, but clearly it wasn't a complete fix and I see no problems without it). * 'z-index: 4' from 6fff13b8983ee929ff1504653a02ce268ea8dc2a (I can't reproduce the issue there after removing it). Bug: T167616 Change-Id: I7e0d603af2668269e5587eaa5e4761166a1b4097 --- M modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget.css 1 file changed, 0 insertions(+), 9 deletions(-) Approvals: DLynch: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget.css b/modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget.css index 7e84780..ef136b3 100644 --- a/modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget.css +++ b/modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget.css @@ -25,15 +25,6 @@ transform: translateY( 0 ); } -.ve-init-mw-desktopArticleTarget-toolbar-opened > .oo-ui-toolbar-bar { - /* Reset trasnform once open to avoid breaking z-index */ - transform: none; -} - -.ve-ui-toolbar-floating > .oo-ui-toolbar-bar { - z-index: 4; -} - /*! * ve-redirect-header is added just outside of the surface, which has its own * hiding style during activation. -- To view, visit https://gerrit.wikimedia.org/r/359034 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e0d603af2668269e5587eaa5e4761166a1b4097 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Bartosz DziewoĆski <matma....@gmail.com> Gerrit-Reviewer: DLynch <dly...@wikimedia.org> Gerrit-Reviewer: Esanders <esand...@wikimedia.org> Gerrit-Reviewer: Krinkle <krinklem...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits