Subramanya Sastry has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/361591 )
Change subject: Linter: Log error when DSR is missing
......................................................................
Linter: Log error when DSR is missing
* Don't push the message into the lint buffer in that case.
Change-Id: I85cce5c55f00c13e71c563b31827adca0220df79
---
M lib/logger/LintLogger.js
1 file changed, 6 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid
refs/changes/91/361591/1
diff --git a/lib/logger/LintLogger.js b/lib/logger/LintLogger.js
index 518a3f9..f5b6a63 100644
--- a/lib/logger/LintLogger.js
+++ b/lib/logger/LintLogger.js
@@ -94,13 +94,14 @@
var dsr = lintObj.dsr;
if (dsr) {
msg.dsr = dsr;
- }
+ if (lintObj.templateInfo) {
+ msg.templateInfo = lintObj.templateInfo;
+ }
- if (lintObj.templateInfo) {
- msg.templateInfo = lintObj.templateInfo;
+ this.buffer.push(msg);
+ } else {
+ this._env.log("error/lint", "Missing DSR; msg=", msg);
}
-
- this.buffer.push(msg);
} catch (e) {
this._env.log("error/lint", "Error in linterBackend: " + e);
} finally {
--
To view, visit https://gerrit.wikimedia.org/r/361591
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I85cce5c55f00c13e71c563b31827adca0220df79
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <ssas...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
