Dzahn has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/361599 )
Change subject: smokeping: ensure dnsutils is installed, use require_package
......................................................................
smokeping: ensure dnsutils is installed, use require_package
smokeping did not run on netmon1002 because:
ERROR: /etc/smokeping/config.d/Probes, line 17: ERROR: DNS 'binary' does not
point to an executable
line 17 is: binary = /usr/bin/dig
dig is missing because it gets only installed from package dnsutils, which
isn't here
by default or from base, at least not now in stretch.
Ensure it is installed, also use require_package() to install all required
packages.
Bug: 159756
Change-Id: I2582bb73085b8f3991c065eb7017eacce02a5ec2
---
M modules/smokeping/manifests/init.pp
1 file changed, 1 insertion(+), 6 deletions(-)
Approvals:
jenkins-bot: Verified
Dzahn: Looks good to me, approved
diff --git a/modules/smokeping/manifests/init.pp
b/modules/smokeping/manifests/init.pp
index a52c578..9cffdca 100644
--- a/modules/smokeping/manifests/init.pp
+++ b/modules/smokeping/manifests/init.pp
@@ -1,11 +1,6 @@
class smokeping {
- package { 'smokeping':
- ensure => present,
- }
- package { 'curl':
- ensure => present,
- }
+ require_package('smokeping', 'curl', 'dnsutils')
file { '/etc/smokeping/config.d':
ensure => directory,
--
To view, visit https://gerrit.wikimedia.org/r/361599
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2582bb73085b8f3991c065eb7017eacce02a5ec2
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn <[email protected]>
Gerrit-Reviewer: Dzahn <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
