Dzahn has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/361551 )
Change subject: jenkins: lack of access_log produce invalid system unit
......................................................................
jenkins: lack of access_log produce invalid system unit
For some reason in .erb "if @fooo" ends up being true when @fooo is an
empty string. Switch to using "undef".
Change-Id: Id115fcf3d013cba457f6b629878ad837a72fdcf1
---
M modules/jenkins/manifests/init.pp
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Dzahn: Looks good to me, approved
diff --git a/modules/jenkins/manifests/init.pp
b/modules/jenkins/manifests/init.pp
index 8d4b17f..d7dcc21 100644
--- a/modules/jenkins/manifests/init.pp
+++ b/modules/jenkins/manifests/init.pp
@@ -112,7 +112,7 @@
before => Service['jenkins'],
}
} else {
- $jenkins_access_log_arg = ''
+ $jenkins_access_log_arg = undef
}
$java_args = join([
--
To view, visit https://gerrit.wikimedia.org/r/361551
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id115fcf3d013cba457f6b629878ad837a72fdcf1
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Hashar <[email protected]>
Gerrit-Reviewer: Dzahn <[email protected]>
Gerrit-Reviewer: Muehlenhoff <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
