Thiemo Mättig (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/361625 )
Change subject: [WIP] Remove unused, unlocalized API error messages
......................................................................
[WIP] Remove unused, unlocalized API error messages
Change-Id: Ie233abe2427f9f74d9ba0878fb6de80b9c37ee62
---
M repo/includes/Api/ApiErrorReporter.php
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/25/361625/1
diff --git a/repo/includes/Api/ApiErrorReporter.php
b/repo/includes/Api/ApiErrorReporter.php
index b7276dc..82aada8 100644
--- a/repo/includes/Api/ApiErrorReporter.php
+++ b/repo/includes/Api/ApiErrorReporter.php
@@ -287,6 +287,10 @@
// NOTE: Use key fallback, so the nominal message key
will be the original.
$params = $description === null ? [] : [ $description ];
$message = wfMessage( [ $messageKey, 'rawmessage' ],
$params );
+ } elseif ( $description ) {
+ throw new LogicException(
+ "Localized message \"$messageKey\" exists,
unlocalized \"$description\" omitted!"
+ );
}
return ApiMessage::create( $message, $errorCode, $data );
--
To view, visit https://gerrit.wikimedia.org/r/361625
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie233abe2427f9f74d9ba0878fb6de80b9c37ee62
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
