WMDE-Fisch has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/361636 )
Change subject: Add basic tracking for submitted conflicts
......................................................................
Add basic tracking for submitted conflicts
Bug: T167862
Change-Id: I8340ba8f56a05fff343d0bef3d5062f85d196cc8
---
M modules/ext.TwoColConflict.init.js
1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TwoColConflict
refs/changes/36/361636/1
diff --git a/modules/ext.TwoColConflict.init.js
b/modules/ext.TwoColConflict.init.js
index d8413d5..e9ca5f8 100644
--- a/modules/ext.TwoColConflict.init.js
+++ b/modules/ext.TwoColConflict.init.js
@@ -189,6 +189,18 @@
windowManager.openWindow( versionSelector );
}
+ function submitEventIsTriggeredBySave( e ) {
+ return $( e.originalEvent.explicitOriginalTarget ).attr( 'id' )
=== 'wpSave';
+ }
+
+ function initSubmitTracking() {
+ $( '#editform' ).on( 'submit', function ( e ) {
+ if ( submitEventIsTriggeredBySave( e ) ) {
+ mw.track( 'TwoColConflict.conflict.submit' );
+ }
+ } );
+ }
+
$( function () {
$( '.mw-twocolconflict-changes-editor' ).keydown( function ( e
) {
if ( e.ctrlKey && e.keyCode === 65 ) { // CTRL + A
@@ -208,5 +220,7 @@
helpDialog.show();
settings.setHideHelpDialogue( true );
}
+
+ initSubmitTracking();
} );
}( mediaWiki, jQuery ) );
--
To view, visit https://gerrit.wikimedia.org/r/361636
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8340ba8f56a05fff343d0bef3d5062f85d196cc8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TwoColConflict
Gerrit-Branch: master
Gerrit-Owner: WMDE-Fisch <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
