jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/361509 )
Change subject: Remove warning when badge label can not be found
......................................................................
Remove warning when badge label can not be found
I added it but now I think it shouldn't be there because all clients
can't have label for badges they show and it will flood logs
Bug: T73887
Change-Id: Ib27d29507132b1ecc9391ac7b078b39cfd656b1c
---
M client/includes/Hooks/SidebarLinkBadgeDisplay.php
1 file changed, 0 insertions(+), 3 deletions(-)
Approvals:
WMDE-leszek: Looks good to me, but someone else must approve
jenkins-bot: Verified
Thiemo Mättig (WMDE): Looks good to me, approved
diff --git a/client/includes/Hooks/SidebarLinkBadgeDisplay.php
b/client/includes/Hooks/SidebarLinkBadgeDisplay.php
index b4094ba..0b596b6 100644
--- a/client/includes/Hooks/SidebarLinkBadgeDisplay.php
+++ b/client/includes/Hooks/SidebarLinkBadgeDisplay.php
@@ -67,9 +67,6 @@
$sidebarLink['class'] = $badgeClass;
}
- if ( !$badgeInfo['label'] ) {
- wfLogWarning( "Label for badge class $badgeClass could
not be found." );
- }
$sidebarLink['itemtitle'] = $badgeInfo['label'];
}
--
To view, visit https://gerrit.wikimedia.org/r/361509
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib27d29507132b1ecc9391ac7b078b39cfd656b1c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup <[email protected]>
Gerrit-Reviewer: Aleksey Bekh-Ivanov (WMDE) <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: WMDE-leszek <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
