Gehel has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/361645 )
Change subject: elasticsearch: pass $publish_host in specs
......................................................................
elasticsearch: pass $publish_host in specs
I tried setting 'ipaddress' as a facts, but somehow rspec-puppet does
not seem to initialize $facts.
Change-Id: I3d2ceaf60d1eb4d8b13fac74d6f0847c92b9d598
---
M modules/elasticsearch/spec/classes/elasticsearch_rspec.rb
M modules/elasticsearch/spec/classes/ship_logs_to_logstash_rspec.rb
2 files changed, 7 insertions(+), 2 deletions(-)
Approvals:
jenkins-bot: Verified
Gehel: Looks good to me, approved
diff --git a/modules/elasticsearch/spec/classes/elasticsearch_rspec.rb
b/modules/elasticsearch/spec/classes/elasticsearch_rspec.rb
index c2a8503..b696f7a 100644
--- a/modules/elasticsearch/spec/classes/elasticsearch_rspec.rb
+++ b/modules/elasticsearch/spec/classes/elasticsearch_rspec.rb
@@ -9,6 +9,7 @@
let(:params) { {
:cluster_name => 'my_cluster_name',
:gc_log => true,
+ :publish_host => '127.0.0.1',
} }
it {
is_expected.to contain_file('/etc/elasticsearch/jvm.options')
diff --git a/modules/elasticsearch/spec/classes/ship_logs_to_logstash_rspec.rb
b/modules/elasticsearch/spec/classes/ship_logs_to_logstash_rspec.rb
index 277729c..fd700f5 100644
--- a/modules/elasticsearch/spec/classes/ship_logs_to_logstash_rspec.rb
+++ b/modules/elasticsearch/spec/classes/ship_logs_to_logstash_rspec.rb
@@ -2,7 +2,9 @@
describe 'elasticsearch', :type => :class do
describe 'when NOT sending logs to logstash' do
- let(:params) { { :cluster_name => 'my_cluster_name' } }
+ let(:params) { { :cluster_name => 'my_cluster_name',
+ :publish_host => '127.0.0.1',
+ } }
let(:facts) { { :lsbdistrelease => 'ubuntu',
:lsbdistid => 'trusty'
} }
@@ -12,7 +14,9 @@
describe 'when sending logs to logstash' do
let(:params) { { :cluster_name => 'my_cluster_name',
- :graylog_hosts => [ 'logstash.example.net', 'other' ] } }
+ :graylog_hosts => [ 'logstash.example.net', 'other' ],
+ :publish_host => '127.0.0.1',
+ } }
let(:facts) { { :lsbdistrelease => 'ubuntu',
:lsbdistid => 'trusty'
} }
--
To view, visit https://gerrit.wikimedia.org/r/361645
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d2ceaf60d1eb4d8b13fac74d6f0847c92b9d598
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Hashar <[email protected]>
Gerrit-Reviewer: Gehel <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
