jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/361602 )
Change subject: RCFilters: Always use the filled bookmark icon (unClip)
......................................................................
RCFilters: Always use the filled bookmark icon (unClip)
Bug: T168828
Change-Id: I436f00bc87db143116125a185abd8000132df195
---
M
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
1 file changed, 2 insertions(+), 11 deletions(-)
Approvals:
jenkins-bot: Verified
Mooeypoo: Looks good to me, approved
diff --git
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
index 3f920f0..1a68b49 100644
---
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
+++
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
@@ -24,7 +24,7 @@
// Parent
mw.rcfilters.ui.SaveFiltersPopupButtonWidget.parent.call( this,
$.extend( {
framed: false,
- icon: 'clip',
+ icon: 'unClip',
$overlay: this.$overlay,
title: mw.msg( 'rcfilters-savedqueries-add-new-title' ),
popup: {
@@ -36,7 +36,7 @@
}
}, config ) );
// // HACK: Add an icon to the popup head label
- this.popup.$head.prepend( ( new OO.ui.IconWidget( { icon:
'clip' } ) ).$element );
+ this.popup.$head.prepend( ( new OO.ui.IconWidget( { icon:
'unClip' } ) ).$element );
this.input = new OO.ui.TextInputWidget( {
validate: /\S/
@@ -107,15 +107,6 @@
this.popup.toggle( false );
return false;
}
- };
-
- /**
- * Respond to popup toggle event
- *
- * @param {boolean} isVisible Popup is visible
- */
- mw.rcfilters.ui.SaveFiltersPopupButtonWidget.prototype.onPopupToggle =
function ( isVisible ) {
- this.setIcon( isVisible ? 'unClip' : 'clip' );
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/361602
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I436f00bc87db143116125a185abd8000132df195
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Mooeypoo <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
