Foxy brown has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/361840 )
Change subject: Article Reminder UI button
......................................................................
Article Reminder UI button
Adding the subject
Bug: T168387
Change-Id: Ic0f8149721af146cfa78db9b4d23583f1fcd2746
---
M Hooks.php
M extension.json
A images/article-reminder.png
A modules/ext.echo.article-reminder.init.js
A modules/styles/mw.echo.ui.ArticleReminderWidget.less
5 files changed, 31 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/40/361840/1
diff --git a/Hooks.php b/Hooks.php
index 303eede..5a87c3d 100644
--- a/Hooks.php
+++ b/Hooks.php
@@ -855,9 +855,15 @@
* @return bool true in all cases
*/
public static function beforePageDisplay( $out, $skin ) {
+ global $wgAllowArticleReminderNotification;
+
if ( $out->getUser()->isLoggedIn() && $skin->getSkinName() !==
'minerva' ) {
// Load the module for the Notifications flyout
- $out->addModules( [ 'ext.echo.init' ] );
+ $out->addModules( [ 'ext.echo.init' ] );
+
+ if ( $wgAllowArticleReminderNotification ) {
+ $out->addModules( [
'ext.echo.article-reminder.init' ] );
+ }
// Load the styles for the Notifications badge
$out->addModuleStyles( [
'ext.echo.styles.badge',
diff --git a/extension.json b/extension.json
index f214321..9c19aa1 100644
--- a/extension.json
+++ b/extension.json
@@ -237,7 +237,8 @@
"styles/mw.echo.ui.MenuItemWidget.less",
"styles/mw.echo.ui.FooterNoticeWidget.less",
"styles/mw.echo.ui.NotificationsWrapper.less",
- "styles/mw.echo.ui.ConfirmationPopupWidget.less"
+
"styles/mw.echo.ui.ConfirmationPopupWidget.less",
+ "styles/mw.echo.ui.ArticleReminderWidget.less"
],
"skinStyles": {
"monobook": [
@@ -404,6 +405,18 @@
"dependencies": [
"ext.echo.api",
"mediawiki.Uri"
+ ],
+ "targets": [
+ "desktop"
+ ]
+ },
+ "ext.echo.article-reminder.init": {
+ "scripts": [
+ "ext.echo.article-reminder.init.js"
+ ],
+ "dependencies": [
+ "mediawiki.util",
+ "ext.echo.api"
],
"targets": [
"desktop"
@@ -1017,7 +1030,7 @@
"merge_strategy": "array_plus_2d"
},
"AllowArticleReminderNotification": {
- "value": false
+ "value": true
}
},
"manifest_version": 2
diff --git a/images/article-reminder.png b/images/article-reminder.png
new file mode 100644
index 0000000..adb7a62
--- /dev/null
+++ b/images/article-reminder.png
Binary files differ
diff --git a/modules/ext.echo.article-reminder.init.js
b/modules/ext.echo.article-reminder.init.js
new file mode 100644
index 0000000..66e04b3
--- /dev/null
+++ b/modules/ext.echo.article-reminder.init.js
@@ -0,0 +1,6 @@
+( function ( mw, $ ) {
+ 'use strict';
+ // Load the button to the right place
+ var articleReminderButton = mw.util.addPortletLink( 'p-views', '.',
'Article Reminder', 'ca-remind', 'Remind me about this article', 'a' );
+ articleReminderButton.className += ' collapsible icon
mw-article-reminder-button';
+}( mediaWiki, jQuery ) );
diff --git a/modules/styles/mw.echo.ui.ArticleReminderWidget.less
b/modules/styles/mw.echo.ui.ArticleReminderWidget.less
new file mode 100644
index 0000000..0ce699c
--- /dev/null
+++ b/modules/styles/mw.echo.ui.ArticleReminderWidget.less
@@ -0,0 +1,3 @@
+li.icon.mw-article-reminder-button a{
+ background-image: url(../../images/article-reminder.png);
+}
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/361840
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0f8149721af146cfa78db9b4d23583f1fcd2746
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Foxy brown <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
