20after4 has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/361941 )
Change subject: VisualEditorHooks#onDiffViewHeader: Don't add type hint as the
hook sucks
......................................................................
VisualEditorHooks#onDiffViewHeader: Don't add type hint as the hook sucks
It'd be nice if the hook didn't.
Bug: T169132
Change-Id: Iabe75448bbedebf8164d9c8223a4d59d0281e66e
---
M VisualEditor.hooks.php
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/41/361941/1
diff --git a/VisualEditor.hooks.php b/VisualEditor.hooks.php
index 3d3eaaa..1415e4b 100644
--- a/VisualEditor.hooks.php
+++ b/VisualEditor.hooks.php
@@ -79,8 +79,8 @@
public static function onDiffViewHeader(
DifferenceEngine $diff,
- Revision $oldRev,
- Revision $newRev
+ /* Revision */ $oldRev,
+ /* Revision */ $newRev
) {
$config = ConfigFactory::getDefaultInstance()->makeConfig(
'visualeditor' );
$output = RequestContext::getMain()->getOutput();
--
To view, visit https://gerrit.wikimedia.org/r/361941
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iabe75448bbedebf8164d9c8223a4d59d0281e66e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: wmf/1.30.0-wmf.7
Gerrit-Owner: 20after4 <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
