20after4 has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/362080 )
Change subject: Set onDiffViewHeader argument defaults = null
......................................................................
Set onDiffViewHeader argument defaults = null
See also I1221357746f5d4ba1430bcf0bfe773202484eebc
Change-Id: I0b96a9557ed1fc0e9a74e14bc25753ecddd97d1d
---
M src/RevisionSliderHooks.php
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RevisionSlider
refs/changes/80/362080/1
diff --git a/src/RevisionSliderHooks.php b/src/RevisionSliderHooks.php
index e6be41d..c8f35f3 100644
--- a/src/RevisionSliderHooks.php
+++ b/src/RevisionSliderHooks.php
@@ -37,8 +37,8 @@
*/
public static function onDiffViewHeader(
DifferenceEngine $diff,
- Revision $oldRev,
- Revision $newRev
+ Revision $oldRev=null,
+ Revision $newRev=null
) {
// sometimes $oldRev can be null (e.g. missing rev), and
perhaps also $newRev (T167359)
if ( !( $oldRev instanceof Revision ) || !( $newRev instanceof
Revision ) ) {
--
To view, visit https://gerrit.wikimedia.org/r/362080
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b96a9557ed1fc0e9a74e14bc25753ecddd97d1d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: 20after4 <mmod...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
