20after4 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362130 )
Change subject: Set onDiffViewHeader argument defaults = null ...................................................................... Set onDiffViewHeader argument defaults = null As suggested by Bartosz in https://gerrit.wikimedia.org/r/#/c/361938/ Just set a default value but keep the type hint. This should avoid the logspam while retaining type safety. Bug: T169132 Change-Id: I1221357746f5d4ba1430bcf0bfe773202484eebc (cherry picked from commit c14b1c46a9ea5b4083346d320c940b30c2cfc551) --- M VisualEditor.hooks.php 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/30/362130/1 diff --git a/VisualEditor.hooks.php b/VisualEditor.hooks.php index 1415e4b..1a27f4c 100644 --- a/VisualEditor.hooks.php +++ b/VisualEditor.hooks.php @@ -79,8 +79,8 @@ public static function onDiffViewHeader( DifferenceEngine $diff, - /* Revision */ $oldRev, - /* Revision */ $newRev + Revision $oldRev = null, + Revision $newRev = null ) { $config = ConfigFactory::getDefaultInstance()->makeConfig( 'visualeditor' ); $output = RequestContext::getMain()->getOutput(); -- To view, visit https://gerrit.wikimedia.org/r/362130 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1221357746f5d4ba1430bcf0bfe773202484eebc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: wmf/1.30.0-wmf.7 Gerrit-Owner: 20after4 <mmod...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
