jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/362162 )
Change subject: Checklist: Fix for Unicode characters
......................................................................
Checklist: Fix for Unicode characters
Using special unicode characters was causing correct item in the checklist
not to be selected.
It is because it was comparing value coming from the parser (decoded) and
raw value from wikitext (encoded)
Change-Id: I5708e6deee0b12ee315b328b032e60e8d5ceaaed
ERM: #6528
---
M Checklist/Checklist.class.php
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Mglaser: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Checklist/Checklist.class.php b/Checklist/Checklist.class.php
index ab0a773..39f8723 100644
--- a/Checklist/Checklist.class.php
+++ b/Checklist/Checklist.class.php
@@ -217,7 +217,9 @@
if ( isset( $aOptionSet[1] ) ) {
$sOut[] =
"style='color:".$aOptionSet[1].";' ";
}
- if ( $bDefault || $args['value'] == $sOption ) {
+
+ $sDecodedOption = html_entity_decode( $sOption
);
+ if ( $bDefault || $args['value'] ==
$sDecodedOption ) {
$bDefault = false;
$sOut[] = "selected='selected'";
if ( isset( $aOptionSet[1] ) ) {
--
To view, visit https://gerrit.wikimedia.org/r/362162
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5708e6deee0b12ee315b328b032e60e8d5ceaaed
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: REL1_23
Gerrit-Owner: ItSpiderman <[email protected]>
Gerrit-Reviewer: Mglaser <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
