[MediaWiki-commits] [Gerrit] mediawiki...Citoid[master]: Disable 'auto' tab if type map isn't setup

[Esanders (Code Review)]

Esanders has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/362230 )

Change subject: Disable 'auto' tab if type map isn't setup
......................................................................

Disable 'auto' tab if type map isn't setup

Bug: T169219
Change-Id: I6653700e833f4804537826693d6fad82e60e1208
---
M modules/ve.ui.CiteFromIdInspector.js
1 file changed, 9 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Citoid 
refs/changes/30/362230/1

diff --git a/modules/ve.ui.CiteFromIdInspector.js 
b/modules/ve.ui.CiteFromIdInspector.js
index ec17cdc..b4d88b9 100644
--- a/modules/ve.ui.CiteFromIdInspector.js
+++ b/modules/ve.ui.CiteFromIdInspector.js
@@ -170,6 +170,9 @@
                this.modePanels.reuse
        ] );
 
+       this.modeIndex.getTabPanel( 'auto' ).tabItem.setDisabled( 
!this.templateTypeMap );
+       this.defaultPanel = this.templateTypeMap ? 'auto' : 'manual';
+
        // Auto mode
        this.autoProcessStack = new OO.ui.StackLayout( {
                expanded: false,
@@ -280,10 +283,10 @@
        var inspector = this;
 
        if ( [ 'auto', 'manual', 'reuse' ].indexOf( tabPanelName ) === -1 ) {
-               tabPanelName = 'auto';
-       } else if ( tabPanelName === 'reuse' && this.modeIndex.getTabPanel( 
'reuse' ).tabItem.isDisabled() ) {
-               tabPanelName = 'auto';
-       } else if ( tabPanelName !== ( ve.userConfig( 'citoid-mode' ) || 'auto' 
) ) {
+               tabPanelName = this.defaultPanel;
+       } else if ( this.modeIndex.getTabPanel( tabPanelName 
).tabItem.isDisabled() ) {
+               tabPanelName = this.defaultPanel;
+       } else if ( tabPanelName !== ( ve.userConfig( 'citoid-mode' ) || 
this.defaultPanel ) ) {
                ve.userConfig( 'citoid-mode', tabPanelName );
        }
 
@@ -480,7 +483,7 @@
                                this.executeAction( 'lookup' );
                        }
 
-                       this.modeIndex.setTabPanel( data.lookup ? 'auto' : ( 
ve.userConfig( 'citoid-mode' ) || 'auto' ) );
+                       this.modeIndex.setTabPanel( data.lookup ? 
this.defaultPanel : ( ve.userConfig( 'citoid-mode' ) || this.defaultPanel ) );
                }, this );
 };
 
@@ -491,7 +494,7 @@
        return ve.ui.CiteFromIdInspector.super.prototype.getReadyProcess.call( 
this, data )
                .next( function () {
                        // Set the panel after ready as it focuses the input too
-                       var mode = data.lookup ? 'auto' : ( ve.userConfig( 
'citoid-mode' ) || 'auto' );
+                       var mode = data.lookup ? this.defaultPanel : ( 
ve.userConfig( 'citoid-mode' ) || this.defaultPanel );
                        this.setModePanel( mode, mode === 'auto' ? 'lookup' : 
undefined );
                }, this );
 };

-- 
To view, visit https://gerrit.wikimedia.org/r/362230
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6653700e833f4804537826693d6fad82e60e1208
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Citoid
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits