WMDE-leszek has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/362239 )
Change subject: Remove entity creation permission logic checks from
Api\EditEntity
......................................................................
Remove entity creation permission logic checks from Api\EditEntity
EntityPermissionChecker implementation should take care of this.
Bug: T166586
Change-Id: I7868f0336f51c17276cb4c56e592424b60034702
---
M repo/includes/Api/EditEntity.php
1 file changed, 0 insertions(+), 22 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/39/362239/1
diff --git a/repo/includes/Api/EditEntity.php b/repo/includes/Api/EditEntity.php
index ef2aa1e..8d26506 100644
--- a/repo/includes/Api/EditEntity.php
+++ b/repo/includes/Api/EditEntity.php
@@ -150,28 +150,6 @@
}
/**
- * @param EntityDocument $entity
- *
- * @throws InvalidArgumentException
- * @return string[] A list of permissions
- */
- protected function getRequiredPermissions( EntityDocument $entity ) {
- $permissions = $this->isWriteMode() ? array( 'read', 'edit' ) :
array( 'read' );
-
- if ( !$this->entityExists( $entity->getId() ) ) {
- $permissions[] = 'createpage';
-
- switch ( $entity->getType() ) {
- case 'property':
- $permissions[] = $entity->getType() .
'-create'; //property-create
- break;
- }
- }
-
- return $permissions;
- }
-
- /**
* @param EntityId $entityId
*
* @return bool
--
To view, visit https://gerrit.wikimedia.org/r/362239
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7868f0336f51c17276cb4c56e592424b60034702
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: WMDE-leszek <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
